# Date: Fri Jan 13 00:10:57 EST 2006
# Module: qos
# Repository: /cvsroot/qos
# Tag: HEAD
# Rulesets: unusedcode.xml
PMD

Summary

Rule nameNumber of violations
EmptyStatementNotInLoop8
UnnecessaryReturn1
CollapsibleIfStatements31
UnusedLocalVariable69
UnusedPrivateMethod11
UnusedFormalParameter19
EmptyIfStmt17
EmptyCatchBlock6
OverrideBothEqualsAndHashcode2
UnconditionalIfStatement1
UnusedPrivateField22

Detail

#FileLineProblem
1 org/cougaar/core/qos/ca/BeanToFactFacetImpl.java 71 Avoid unused formal parameters such as 'bbs'
2 org/cougaar/core/qos/ca/CoordinationArtifactProviderPlugin.java 47 Avoid unused private fields such as 'impl'
3 org/cougaar/core/qos/ca/QueryFacet.java 172 Avoid empty 'if' statements
4 org/cougaar/core/qos/ca/QueryRelayImpl.java 55 Avoid unused private fields such as 'target'
5 org/cougaar/core/qos/ca/RelayReclaimer.java 53 Avoid unused local variables such as 'now'
6 org/cougaar/core/qos/ca/RelayReclaimer.java 58 Avoid unused local variables such as 'expiration_time'
7 org/cougaar/core/qos/ca/RelayReclaimer.java 59 Do not use 'if' statements that are always true or always false
8 org/cougaar/core/qos/ca/ResponseFacet.java 157 Avoid empty 'if' statements
9 org/cougaar/core/qos/ca/ResponseFacet.java 166 Avoid unused local variables such as 'timestamp'
10 org/cougaar/core/qos/ca/ResponseRelayImpl.java 54 Avoid unused private fields such as 'target'
11 org/cougaar/core/qos/ca/SleeperFacet.java 67 Avoid empty 'if' statements
12 org/cougaar/core/qos/frame/DataFrame.java 124 Avoid unused local variables such as 'klass'
13 org/cougaar/core/qos/frame/DataFrame.java 139 Avoid unused formal parameters such as 'pkg'
14 org/cougaar/core/qos/frame/DataFrame.java 139 Avoid unused private methods such as 'newFrameReflective(String,FrameSet,String,UID,Properties)'
15 org/cougaar/core/qos/frame/DataFrame.java 431 These nested if statements could be combined
16 org/cougaar/core/qos/frame/DataFrame.java 455 Avoid unused private methods such as 'getAllSlotsReflective()'
17 org/cougaar/core/qos/frame/DataFrame.java 789 Avoid unused private methods such as 'getLocalValueReflective(String)'
18 org/cougaar/core/qos/frame/DataFrame.java 810 Avoid unused private methods such as 'setLocalValueReflective(String,Object)'
19 org/cougaar/core/qos/frame/DataFrame.java 827 Avoid unused private methods such as 'removeLocalValueReflective(String)'
20 org/cougaar/core/qos/frame/DataFrame.java 843 Avoid unused private methods such as 'initializeLocalValueReflective(String,Object)'
21 org/cougaar/core/qos/frame/FactToFrameFacetImpl.java 198 Avoid empty 'if' statements
22 org/cougaar/core/qos/frame/FactToFrameFacetImpl.java 201 Avoid empty 'if' statements
23 org/cougaar/core/qos/frame/FrameGen.java 110 Avoid unused private fields such as 'container_relation'
24 org/cougaar/core/qos/frame/FrameGen.java 166 Avoid empty 'if' statements
25 org/cougaar/core/qos/frame/FrameGen.java 188 Avoid empty 'if' statements
26 org/cougaar/core/qos/frame/FrameGen.java 328 Avoid unused formal parameters such as 'proto'
27 org/cougaar/core/qos/frame/FrameGen.java 379 Avoid unused formal parameters such as 'pkg'
28 org/cougaar/core/qos/frame/FrameGen.java 558 Avoid unused local variables such as 'value'
29 org/cougaar/core/qos/frame/FrameGen.java 624 Avoid unused formal parameters such as 'prototype'
30 org/cougaar/core/qos/frame/FrameGen.java 743 Avoid unused local variables such as 'path'
31 org/cougaar/core/qos/frame/FrameGen.java 745 Avoid unused local variables such as 'warnp'
32 org/cougaar/core/qos/frame/FrameGen.java 790 Avoid unused local variables such as 'path'
33 org/cougaar/core/qos/frame/FrameGen.java 792 Avoid unused local variables such as 'warnp'
34 org/cougaar/core/qos/frame/FrameGen.java 818 Avoid unused formal parameters such as 'prototype'
35 org/cougaar/core/qos/frame/FrameGen.java 846 Avoid unused formal parameters such as 'prototype'
36 org/cougaar/core/qos/frame/FrameGen.java 869 Avoid unused formal parameters such as 'attrs'
37 org/cougaar/core/qos/frame/FrameGen.java 905 Avoid unused formal parameters such as 'attrs'
38 org/cougaar/core/qos/frame/FrameGen.java 942 Avoid unused formal parameters such as 'attrs'
39 org/cougaar/core/qos/frame/FrameGen.java 942 Avoid unused formal parameters such as 'type'
40 org/cougaar/core/qos/frame/FrameGen.java 953 Avoid unused local variables such as 'fixed_name'
41 org/cougaar/core/qos/frame/FrameGen.java 968 Avoid unused formal parameters such as 'attrs'
42 org/cougaar/core/qos/frame/FrameGen.java 990 Avoid unused formal parameters such as 'attrs'
43 org/cougaar/core/qos/frame/FrameGen.java 1021 Avoid unused formal parameters such as 'container'
44 org/cougaar/core/qos/frame/FrameGen.java 1080 Avoid unused local variables such as 'accessor_name'
45 org/cougaar/core/qos/frame/FrameGen.java 1129 Avoid unused formal parameters such as 'prototype'
46 org/cougaar/core/qos/frame/FrameGen.java 1227 Avoid unused formal parameters such as 'prototype'
47 org/cougaar/core/qos/frame/FrameGen.java 1268 Avoid unused local variables such as 'attrs'
48 org/cougaar/core/qos/frame/FrameGen.java 1271 Avoid unused local variables such as 'type'
49 org/cougaar/core/qos/frame/FrameGen.java 1306 Avoid unused local variables such as 'attrs'
50 org/cougaar/core/qos/frame/FrameGen.java 1307 Avoid unused local variables such as 'type'
51 org/cougaar/core/qos/frame/FrameGen.java 1367 Avoid unused local variables such as 'type'
52 org/cougaar/core/qos/frame/FrameGen.java 1386 Avoid unused formal parameters such as 'prototype'
53 org/cougaar/core/qos/frame/FrameGen.java 1469 Avoid unused local variables such as 'slot'
54 org/cougaar/core/qos/frame/FrameGen.java 1520 Avoid unused private methods such as 'descendsFrom(String,String)'
55 org/cougaar/core/qos/frame/FrameGen.java 1575 Avoid unused private methods such as 'collectSlots(String,HashMap)'
56 org/cougaar/core/qos/frame/FrameGen.java 1754 Avoid unused local variables such as 'attrs'
57 org/cougaar/core/qos/frame/FrameSetParser.java 248 Avoid empty 'if' statements
58 org/cougaar/core/qos/frame/FrameSetParser.java 282 Avoid empty 'if' statements
59 org/cougaar/core/qos/frame/FrameSetParser.java 294 Avoid empty 'if' statements
60 org/cougaar/core/qos/frame/FrameSetParser.java 296 Avoid empty 'if' statements
61 org/cougaar/core/qos/frame/FrameSetParser.java 298 Avoid empty 'if' statements
62 org/cougaar/core/qos/frame/FrameSetParser.java 438 Avoid empty 'if' statements
63 org/cougaar/core/qos/frame/FrameSetParser.java 451 Avoid empty 'if' statements
64 org/cougaar/core/qos/frame/FrameSetServicePlugin.java 50 Avoid unused private fields such as 'log'
65 org/cougaar/core/qos/frame/FrameViewerServlet.java 94 Ensure you override both equals() and hashCode()
66 org/cougaar/core/qos/frame/FrameViewerServlet.java 587 Avoid unused private methods such as 'getParameter(String,String)'
67 org/cougaar/core/qos/frame/PrototypeFrame.java 147 These nested if statements could be combined
68 org/cougaar/core/qos/frame/RelationFrame.java 43 Avoid unused private fields such as 'log'
69 org/cougaar/core/qos/frame/SingleInheritanceFrameSet.java 132 Avoid unused local variables such as 'resolved'
70 org/cougaar/core/qos/frame/topology/Agent.java 505 These nested if statements could be combined
71 org/cougaar/core/qos/frame/topology/Agent.java 512 These nested if statements could be combined
72 org/cougaar/core/qos/frame/topology/Agent.java 519 These nested if statements could be combined
73 org/cougaar/core/qos/frame/topology/Agent.java 526 These nested if statements could be combined
74 org/cougaar/core/qos/frame/topology/Agent.java 533 These nested if statements could be combined
75 org/cougaar/core/qos/frame/topology/Indicator.java 449 These nested if statements could be combined
76 org/cougaar/core/qos/frame/topology/Indicator.java 456 These nested if statements could be combined
77 org/cougaar/core/qos/frame/topology/Indicator.java 463 These nested if statements could be combined
78 org/cougaar/core/qos/frame/topology/Indicator.java 470 These nested if statements could be combined
79 org/cougaar/core/qos/frame/topology/Indicator.java 477 These nested if statements could be combined
80 org/cougaar/core/qos/frame/topology/Indicator.java 484 These nested if statements could be combined
81 org/cougaar/core/qos/frame/topology/Indicator.java 491 These nested if statements could be combined
82 org/cougaar/core/qos/frame/topology/Indicator.java 498 These nested if statements could be combined
83 org/cougaar/core/qos/frame/topology/Indicator.java 505 These nested if statements could be combined
84 org/cougaar/core/qos/frame/topology/Indicator.java 512 These nested if statements could be combined
85 org/cougaar/core/qos/frame/topology/Indicator.java 519 These nested if statements could be combined
86 org/cougaar/core/qos/frame/topology/Indicator.java 526 These nested if statements could be combined
87 org/cougaar/core/qos/frame/topology/Node.java 478 These nested if statements could be combined
88 org/cougaar/core/qos/frame/topology/Node.java 485 These nested if statements could be combined
89 org/cougaar/core/qos/frame/topology/Node.java 492 These nested if statements could be combined
90 org/cougaar/core/qos/frame/topology/Node.java 499 These nested if statements could be combined
91 org/cougaar/core/qos/frame/topology/Thing.java 98 Avoid unused local variables such as '__key'
92 org/cougaar/core/qos/frame/topology/TopologyFrameUpdaterPlugin.java 70 Avoid unused private fields such as 'agentHostUpdater'
93 org/cougaar/core/qos/frame/topology/TopologyFrameUpdaterPlugin.java 72 Avoid unused private fields such as 'agents'
94 org/cougaar/core/qos/frame/topology/TopologyFrameUpdaterPlugin.java 73 Avoid unused private fields such as 'nodes'
95 org/cougaar/core/qos/frame/topology/TopologyFrameUpdaterPlugin.java 74 Avoid unused private fields such as 'hosts'
96 org/cougaar/core/qos/frame/topology/TopologyFrameUpdaterPlugin.java 89 Avoid unused local variables such as 'agentAddress'
97 org/cougaar/core/qos/frame/topology/TopologyFrameUpdaterPlugin.java 209 Avoid unused private methods such as 'findIndicator(String)'
98 org/cougaar/core/qos/frame/topology/TopologyFrameUpdaterPlugin.java 222 Avoid unused local variables such as 'agentFrame'
99 org/cougaar/core/qos/frame/topology/TopologyFrameUpdaterPlugin.java 223 Avoid unused local variables such as 'nodeFrame'
100 org/cougaar/core/qos/frame/topology/TopologyFrameUpdaterPlugin.java 224 Avoid unused local variables such as 'hostFrame'
101 org/cougaar/core/qos/frame/topology/TopologyFrameUpdaterPlugin.java 225 Avoid unused local variables such as 'agentRelationship'
102 org/cougaar/core/qos/frame/topology/TopologyFrameUpdaterPlugin.java 226 Avoid unused local variables such as 'nodeRelationship'
103 org/cougaar/core/qos/frame/topology/TopologyFrameUpdaterPlugin.java 394 Avoid unused local variables such as 'added'
104 org/cougaar/core/qos/frame/topology/TopologyFrameUpdaterPlugin.java 466 Avoid unused private fields such as 'indicatorSubscription'
105 org/cougaar/core/qos/frame/topology/TopologyFrameUpdaterPlugin.java 472 Avoid unused private fields such as 'indicatorPredicate'
106 org/cougaar/core/qos/frame/visualizer/Display.java 91 These nested if statements could be combined
107 org/cougaar/core/qos/frame/visualizer/Display.java 167 An empty statement (semicolon) not part of a loop
108 org/cougaar/core/qos/frame/visualizer/Display.java 185 These nested if statements could be combined
109 org/cougaar/core/qos/frame/visualizer/Display.java 211 Avoid unused local variables such as 'child'
110 org/cougaar/core/qos/frame/visualizer/Display.java 211 Avoid unused local variables such as 'parent'
111 org/cougaar/core/qos/frame/visualizer/Display.java 212 Avoid unused local variables such as 'fchild'
112 org/cougaar/core/qos/frame/visualizer/Display.java 212 Avoid unused local variables such as 'fparent'
113 org/cougaar/core/qos/frame/visualizer/Display.java 220 Avoid unused local variables such as 'change'
114 org/cougaar/core/qos/frame/visualizer/DisplayWindow.java 63 Avoid unused local variables such as 'title'
115 org/cougaar/core/qos/frame/visualizer/FrameModel.java 182 These nested if statements could be combined
116 org/cougaar/core/qos/frame/visualizer/FrameModel.java 278 Avoid unused local variables such as 'name'
117 org/cougaar/core/qos/frame/visualizer/FrameModel.java 424 Avoid unused local variables such as 'transitions'
118 org/cougaar/core/qos/frame/visualizer/FrameModel.java 426 Avoid unused local variables such as 'trans'
119 org/cougaar/core/qos/frame/visualizer/FrameVisualizerPlugin.java 61 Avoid unused private fields such as 'pluginDisplay'
120 org/cougaar/core/qos/frame/visualizer/FrameVisualizerPlugin.java 123 Avoid unused formal parameters such as 'bbs'
121 org/cougaar/core/qos/frame/visualizer/ShapeContainer.java 243 Avoid unused local variables such as 'f2'
122 org/cougaar/core/qos/frame/visualizer/ShapeGraphic.java 222 Avoid unused local variables such as 'f'
123 org/cougaar/core/qos/frame/visualizer/ShapeRenderers.java 43 Avoid unused local variables such as 'tag'
124 org/cougaar/core/qos/frame/visualizer/ShapeRenderers.java 44 Avoid unused local variables such as 'fillPaint'
125 org/cougaar/core/qos/frame/visualizer/ShapeRenderers.java 44 Avoid unused local variables such as 'paint'
126 org/cougaar/core/qos/frame/visualizer/ShapeRenderers.java 44 Avoid unused local variables such as 'selectedFillPaint'
127 org/cougaar/core/qos/frame/visualizer/ShapeRenderers.java 44 Avoid unused local variables such as 'selectedPaint'
128 org/cougaar/core/qos/frame/visualizer/ShapeRenderers.java 45 Avoid unused local variables such as 'lineStroke'
129 org/cougaar/core/qos/frame/visualizer/Surface.java 78 Avoid unused private fields such as 'outputPerf'
130 org/cougaar/core/qos/frame/visualizer/Surface.java 97 Avoid empty catch blocks
131 org/cougaar/core/qos/frame/visualizer/Surface.java 419 Avoid unused local variables such as 'tot'
132 org/cougaar/core/qos/frame/visualizer/layout/HorizontalBoxLayout.java 28 Avoid unused local variables such as 'totalheight'
133 org/cougaar/core/qos/frame/visualizer/layout/HorizontalBoxLayout.java 30 Avoid unused local variables such as 'num'
134 org/cougaar/core/qos/frame/visualizer/layout/HorizontalBoxLayout.java 31 Avoid unused local variables such as 'i'
135 org/cougaar/core/qos/frame/visualizer/layout/HorizontalBoxLayout.java 31 Avoid unused local variables such as 'x'
136 org/cougaar/core/qos/frame/visualizer/layout/HorizontalBoxLayout.java 31 Avoid unused local variables such as 'y'
137 org/cougaar/core/qos/frame/visualizer/layout/HorizontalLayout.java 30 Avoid unused local variables such as 'x'
138 org/cougaar/core/qos/frame/visualizer/layout/HorizontalLayout.java 30 Avoid unused local variables such as 'y'
139 org/cougaar/core/qos/frame/visualizer/layout/VerticalBoxLayout.java 28 Avoid unused local variables such as 'num'
140 org/cougaar/core/qos/frame/visualizer/layout/VerticalBoxLayout.java 30 Avoid unused local variables such as 'totalwidth'
141 org/cougaar/core/qos/frame/visualizer/layout/VerticalBoxLayout.java 32 Avoid unused local variables such as 'i'
142 org/cougaar/core/qos/frame/visualizer/layout/VerticalBoxLayout.java 32 Avoid unused local variables such as 'x'
143 org/cougaar/core/qos/frame/visualizer/layout/VerticalBoxLayout.java 32 Avoid unused local variables such as 'y'
144 org/cougaar/core/qos/frame/visualizer/layout/VerticalLayout.java 30 Avoid unused local variables such as 'x'
145 org/cougaar/core/qos/frame/visualizer/layout/VerticalLayout.java 30 Avoid unused local variables such as 'y'
146 org/cougaar/core/qos/frame/visualizer/test/FramePredicate.java 51 Avoid unused local variables such as 'framesetBool'
147 org/cougaar/core/qos/frame/visualizer/tree/FrameTreeView.java 314 Avoid unused local variables such as 'tnode'
148 org/cougaar/core/qos/frame/visualizer/tree/FrameTreeView.java 427 An empty statement (semicolon) not part of a loop
149 org/cougaar/core/qos/frame/visualizer/util/SlotChangeListener.java 37 Avoid unused private fields such as 'log'
150 org/cougaar/core/qos/frame/visualizer/util/SlotChangeListener.java 167 Avoid unused local variables such as 't'
151 org/cougaar/core/qos/frame/visualizer/util/ViewConfigParser.java 130 Avoid unused private fields such as 'log'
152 org/cougaar/core/qos/frame/visualizer/util/ViewConfigParser.java 255 An empty statement (semicolon) not part of a loop
153 org/cougaar/core/qos/frame/visualizer/util/ViewConfigParser.java 255 Avoid empty 'if' statements
154 org/cougaar/core/qos/frame/visualizer/util/ViewConfigParser.java 264 An empty statement (semicolon) not part of a loop
155 org/cougaar/core/qos/frame/visualizer/util/ViewConfigParser.java 264 Avoid empty 'if' statements
156 org/cougaar/core/qos/frame/visualizer/util/ViewConfigParser.java 266 An empty statement (semicolon) not part of a loop
157 org/cougaar/core/qos/frame/visualizer/util/ViewConfigParser.java 266 Avoid empty 'if' statements
158 org/cougaar/core/qos/frame/visualizer/util/ViewConfigParser.java 268 These nested if statements could be combined
159 org/cougaar/core/qos/frame/visualizer/util/ViewConfigParser.java 339 Avoid unused local variables such as 'negativeX'
160 org/cougaar/core/qos/frame/visualizer/util/ViewConfigParser.java 344 Avoid unused local variables such as 'font'
161 org/cougaar/core/qos/frame/visualizer/util/ViewConfigParser.java 360 Avoid unused local variables such as 'font'
162 org/cougaar/core/qos/frame/visualizer/util/ViewConfigParser.java 387 An empty statement (semicolon) not part of a loop
163 org/cougaar/core/qos/frame/visualizer/util/XMLParser.java 20 Avoid unused private fields such as 'UNDEFINED'
164 org/cougaar/core/qos/frame/visualizer/util/XMLParser.java 54 Avoid unnecessary return statements
165 org/cougaar/core/qos/gossip/GossipFeedComponent.java 55 Avoid unused private fields such as 'loggingService'
166 org/cougaar/core/qos/gossip/GossipSubscription.java 73 Avoid unused private fields such as 'neighbor'
167 org/cougaar/core/qos/gossip/GossipSubscription.java 140 Avoid unused private methods such as 'removeKey(String)'
168 org/cougaar/core/qos/gossip/KeyGossip.java 49 Ensure you override both equals() and hashCode()
169 org/cougaar/core/qos/gossip/ValueGossip.java 46 Avoid unused private fields such as 'metric'
170 org/cougaar/core/qos/rss/AgentDS.java 120 Avoid empty catch blocks
171 org/cougaar/core/qos/rss/AgentFlowDS.java 77 Avoid unused private fields such as 'NO_VALUE'
172 org/cougaar/core/qos/rss/AgentHostUpdaterComponent.java 245 Avoid unused formal parameters such as 'uri'
173 org/cougaar/core/qos/rss/AgentHostUpdaterComponent.java 271 These nested if statements could be combined
174 org/cougaar/core/qos/rss/AgentHostUpdaterComponent.java 312 Avoid empty catch blocks
175 org/cougaar/core/qos/rss/AgentHostUpdaterComponent.java 330 These nested if statements could be combined
176 org/cougaar/core/qos/rss/AgentHostUpdaterComponent.java 352 Avoid empty catch blocks
177 org/cougaar/core/qos/rss/AgentHostUpdaterComponent.java 356 These nested if statements could be combined
178 org/cougaar/core/qos/rss/DestinationDS.java 207 Avoid unused local variables such as 'agent'
179 org/cougaar/core/qos/rss/NodeDS.java 128 Avoid empty catch blocks
180 org/cougaar/core/qos/rss/RSSMetricsServiceImpl.java 160 Avoid empty catch blocks
181 org/cougaar/core/qos/rss/RSSMetricsUpdateServiceImpl.java 81 An empty statement (semicolon) not part of a loop
182 org/cougaar/core/qos/tmatrix/AgentFlowAspect.java 66 Avoid unused private fields such as 'log'
183 org/cougaar/core/qos/tmatrix/AgentFlowAspect.java 165 Avoid unused local variables such as 'theNewRecord'
184 org/cougaar/core/qos/tmatrix/AgentFlowServlet.java 66 These nested if statements could be combined
185 org/cougaar/core/qos/tmatrix/TMatrixTracePlugin.java 91 Avoid unused local variables such as 'count'
186 org/cougaar/core/qos/tmatrix/TrafficMatrix.java 143 Avoid unused local variables such as 'log'
187 org/cougaar/core/qos/tmatrix/TrafficMatrix.java 436 An empty statement (semicolon) not part of a loop