# Date: Fri Jan 13 00:09:31 EST 2006
# Module: mtsstd
# Repository: /cvsroot/mts
# Tag: HEAD
# Rulesets: unusedcode.xml
| Rule name | Number of violations |
|---|---|
| UselessOverridingMethod | 3 |
| EmptyWhileStmt | 1 |
| UnusedLocalVariable | 3 |
| CollapsibleIfStatements | 10 |
| UnnecessaryFinalModifier | 8 |
| UnusedPrivateMethod | 15 |
| EmptyIfStmt | 6 |
| OverrideBothEqualsAndHashcode | 3 |
| EmptyCatchBlock | 22 |
| UnusedPrivateField | 8 |
| # | File | Line | Problem |
|---|---|---|---|
| 1 | org/cougaar/mts/base/LinkProtocolFactory.java | 71 | Avoid unused private methods such as 'makeProtocol(String)' |
| 2 | org/cougaar/mts/base/LinkSelectionPolicyServiceProvider.java | 85 | Avoid empty 'if' statements |
| 3 | org/cougaar/mts/base/MTImpl.java | 53 | Avoid unused private fields such as 'sb' |
| 4 | org/cougaar/mts/base/MessageDelivererFactory.java | 63 | These nested if statements could be combined |
| 5 | org/cougaar/mts/base/MessageProtectionServiceImpl.java | 100 | Avoid empty catch blocks |
| 6 | org/cougaar/mts/base/MessageQueue.java | 107 | Avoid empty 'if' statements |
| 7 | org/cougaar/mts/base/MessageTransportRegistry.java | 196 | Avoid empty catch blocks |
| 8 | org/cougaar/mts/base/MessageTransportServiceProvider.java | 340 | Avoid empty 'if' statements |
| 9 | org/cougaar/mts/base/MessageTransportServiceProvider.java | 343 | Avoid empty 'if' statements |
| 10 | org/cougaar/mts/base/MessageTransportServiceProvider.java | 344 | These nested if statements could be combined |
| 11 | org/cougaar/mts/base/NameLookupException.java | 36 | Avoid unused private fields such as 'nested_exception' |
| 12 | org/cougaar/mts/base/NameSupportImpl.java | 89 | Avoid unused private fields such as 'id' |
| 13 | org/cougaar/mts/base/NameSupportImpl.java | 90 | Avoid unused private fields such as 'hostname' |
| 14 | org/cougaar/mts/base/NameSupportImpl.java | 124 | Unnecessary final modifier in final class |
| 15 | org/cougaar/mts/base/NameSupportImpl.java | 138 | Unnecessary final modifier in final class |
| 16 | org/cougaar/mts/base/RMILinkProtocol.java | 211 | These nested if statements could be combined |
| 17 | org/cougaar/mts/base/RMILinkProtocol.java | 243 | Avoid empty catch blocks |
| 18 | org/cougaar/mts/base/RMILinkProtocol.java | 253 | Avoid empty catch blocks |
| 19 | org/cougaar/mts/base/RPCLinkProtocol.java | 91 | Avoid empty 'if' statements |
| 20 | org/cougaar/mts/base/RPCLinkProtocol.java | 375 | Avoid unused private methods such as 'handleWPCallback(AddressEntry,long)' |
| 21 | org/cougaar/mts/base/RPCLinkProtocol.java | 431 | These nested if statements could be combined |
| 22 | org/cougaar/mts/base/ReceiveLinkFactory.java | 49 | These nested if statements could be combined |
| 23 | org/cougaar/mts/base/RouterFactory.java | 56 | These nested if statements could be combined |
| 24 | org/cougaar/mts/base/SocketFactory.java | 71 | Avoid unused private fields such as 'SSL_INSTRUCTIONS' |
| 25 | org/cougaar/mts/base/UnregisteredNameException.java | 42 | Avoid unused private fields such as 'addr' |
| 26 | org/cougaar/mts/corba/CorbaLinkProtocol.java | 161 | Avoid empty catch blocks |
| 27 | org/cougaar/mts/corba/CorbaLinkProtocol.java | 178 | Avoid empty catch blocks |
| 28 | org/cougaar/mts/corba/CorbaLinkProtocol.java | 193 | Avoid empty catch blocks |
| 29 | org/cougaar/mts/corba/CorbaLinkProtocol.java | 195 | Avoid empty catch blocks |
| 30 | org/cougaar/mts/corba/EnableCorbaAspect.java | 75 | Avoid unused local variables such as 'now' |
| 31 | org/cougaar/mts/corba/MTImpl.java | 40 | Avoid unused private fields such as 'address' |
| 32 | org/cougaar/mts/corba/MTImpl.java | 58 | Avoid empty catch blocks |
| 33 | org/cougaar/mts/corba/MTImpl.java | 73 | Avoid empty catch blocks |
| 34 | org/cougaar/mts/corba/MTImpl.java | 74 | Avoid empty catch blocks |
| 35 | org/cougaar/mts/corba/MTImpl.java | 90 | Avoid empty catch blocks |
| 36 | org/cougaar/mts/corba/idlj/CorbaMisdeliveredMessageHelper.java | 44 | Avoid unused local variables such as '_tcOf_members0' |
| 37 | org/cougaar/mts/http/HTTPLinkProtocol.java | 221 | These nested if statements could be combined |
| 38 | org/cougaar/mts/std/AspectSupportImpl.java | 111 | Avoid unused private methods such as 'loadAspectClass(String)' |
| 39 | org/cougaar/mts/std/CachingStreamsAspect.java | 95 | Avoid unused private fields such as 'cache' |
| 40 | org/cougaar/mts/std/DestinationQueueMonitorServlet.java | 428 | Unnecessary final modifier in final class |
| 41 | org/cougaar/mts/std/DestinationQueueMonitorServlet.java | 446 | Avoid unused private methods such as 'encodeUTF8(String)' |
| 42 | org/cougaar/mts/std/DestinationQueueMonitorServlet.java | 446 | Unnecessary final modifier in final class |
| 43 | org/cougaar/mts/std/DestinationQueueMonitorServlet.java | 453 | Avoid unused private methods such as 'decodeUTF8(String)' |
| 44 | org/cougaar/mts/std/DestinationQueueMonitorServlet.java | 453 | Unnecessary final modifier in final class |
| 45 | org/cougaar/mts/std/DestinationQueueMonitorServlet.java | 462 | Unnecessary final modifier in final class |
| 46 | org/cougaar/mts/std/DestinationQueueMonitorServlet.java | 465 | Avoid unused private methods such as 'encodeHTML(String,boolean)' |
| 47 | org/cougaar/mts/std/DestinationQueueMonitorServlet.java | 465 | Unnecessary final modifier in final class |
| 48 | org/cougaar/mts/std/DestinationThreadConstrictor.java | 103 | Avoid empty 'if' statements |
| 49 | org/cougaar/mts/std/DestinationThreadConstrictor.java | 121 | Ensure you override both equals() and hashCode() |
| 50 | org/cougaar/mts/std/DestinationThreadConstrictor.java | 235 | These nested if statements could be combined |
| 51 | org/cougaar/mts/std/ForwardMessageLoggingAspect.java | 74 | Avoid empty catch blocks |
| 52 | org/cougaar/mts/std/ForwardMessageLoggingAspect.java | 146 | Avoid empty 'while' statements |
| 53 | org/cougaar/mts/std/FuseServerSocket.java | 120 | Avoid empty catch blocks |
| 54 | org/cougaar/mts/std/MessageQueueDumpServiceComponent.java | 90 | Unnecessary final modifier in final class |
| 55 | org/cougaar/mts/std/MessageTimeoutAspect.java | 129 | Avoid unused private methods such as 'delivered(MessageAttributes)' |
| 56 | org/cougaar/mts/std/MessageTimeoutAspect.java | 140 | These nested if statements could be combined |
| 57 | org/cougaar/mts/std/MessageTimeoutAspect.java | 220 | These nested if statements could be combined |
| 58 | org/cougaar/mts/std/MessageTraceAspect.java | 56 | Overriding method merely calls super |
| 59 | org/cougaar/mts/std/PrioritizedThreadsAspect.java | 59 | Ensure you override both equals() and hashCode() |
| 60 | org/cougaar/mts/std/RMISocketControlAspect.java | 119 | Avoid unused private methods such as 'getKey(String,int)' |
| 61 | org/cougaar/mts/std/RMISocketControlAspect.java | 123 | Avoid unused private methods such as 'getKey(String,String)' |
| 62 | org/cougaar/mts/std/RMISocketControlAspect.java | 172 | Avoid unused private methods such as 'cacheSocket(Socket)' |
| 63 | org/cougaar/mts/std/RMISocketControlAspect.java | 178 | Avoid empty catch blocks |
| 64 | org/cougaar/mts/std/SecurityAspect.java | 68 | Avoid empty catch blocks |
| 65 | org/cougaar/mts/std/SequenceAspect.java | 158 | Ensure you override both equals() and hashCode() |
| 66 | org/cougaar/mts/std/SequenceAspect.java | 254 | Avoid unused private methods such as 'superDeliverMessage(AttributedMessage)' |
| 67 | org/cougaar/mts/std/SerializedMTImpl.java | 66 | Avoid empty catch blocks |
| 68 | org/cougaar/mts/std/SerializedMTImpl.java | 67 | Avoid empty catch blocks |
| 69 | org/cougaar/mts/std/SerializedMTImpl.java | 77 | Avoid empty catch blocks |
| 70 | org/cougaar/mts/std/SerializedRMILinkProtocol.java | 60 | Overriding method merely calls super |
| 71 | org/cougaar/mts/std/SerializedRMILinkProtocol.java | 83 | Avoid empty catch blocks |
| 72 | org/cougaar/mts/std/SerializedRMILinkProtocol.java | 109 | Avoid empty catch blocks |
| 73 | org/cougaar/mts/std/SerializedRMILinkProtocol.java | 111 | Avoid empty catch blocks |
| 74 | org/cougaar/mts/std/StepperAspect.java | 351 | Avoid unused private methods such as 'pause()' |
| 75 | org/cougaar/mts/std/StepperAspect.java | 358 | Avoid unused private methods such as 'resume()' |
| 76 | org/cougaar/mts/std/StepperAspect.java | 410 | Avoid unused private methods such as 'isStepping()' |
| 77 | org/cougaar/mts/std/StepperAspect.java | 414 | Avoid unused private methods such as 'setStepping(boolean)' |
| 78 | org/cougaar/mts/std/TraceAspect.java | 118 | Overriding method merely calls super |
| 79 | org/cougaar/mts/std/WasteCPUAspect.java | 93 | Avoid unused local variables such as 'count' |