# Date: Fri Jan 13 00:32:05 EST 2006
# Module: csmart
# Repository: /cvsroot/csmart
# Tag: HEAD
# Rulesets: unusedcode.xml
PMD

Summary

Rule nameNumber of violations
ReturnFromFinallyBlock2
CollapsibleIfStatements85
UnusedPrivateMethod44
UnusedFormalParameter13
UnconditionalIfStatement1
EmptyStatementNotInLoop2
UselessOverridingMethod2
UnnecessaryReturn3
UnusedLocalVariable13
UnnecessaryFinalModifier18
EmptyIfStmt28
OverrideBothEqualsAndHashcode14
EmptyCatchBlock64
BooleanInstantiation7
UnusedPrivateField44

Detail

#FileLineProblem
1 org/cougaar/tools/csmart/core/cdata/GenericComponentData.java 323 Avoid empty 'if' statements
2 org/cougaar/tools/csmart/core/cdata/GenericComponentData.java 339 Avoid empty 'if' statements
3 org/cougaar/tools/csmart/core/cdata/GenericComponentData.java 341 These nested if statements could be combined
4 org/cougaar/tools/csmart/core/cdata/GenericComponentData.java 601 Ensure you override both equals() and hashCode()
5 org/cougaar/tools/csmart/core/cdata/GenericComponentData.java 730 These nested if statements could be combined
6 org/cougaar/tools/csmart/core/cdata/GenericComponentData.java 731 These nested if statements could be combined
7 org/cougaar/tools/csmart/core/cdata/GenericLeafComponentData.java 113 Ensure you override both equals() and hashCode()
8 org/cougaar/tools/csmart/core/db/CommunityDbUtils.java 94 Avoid empty catch blocks
9 org/cougaar/tools/csmart/core/db/CommunityDbUtils.java 264 Avoid empty catch blocks
10 org/cougaar/tools/csmart/core/db/CommunityDbUtils.java 276 Avoid unused formal parameters such as 'assemblyID'
11 org/cougaar/tools/csmart/core/db/CommunityDbUtils.java 306 Avoid empty catch blocks
12 org/cougaar/tools/csmart/core/db/CommunityDbUtils.java 319 Avoid unused formal parameters such as 'assemblyID'
13 org/cougaar/tools/csmart/core/db/CommunityDbUtils.java 353 Avoid empty catch blocks
14 org/cougaar/tools/csmart/core/db/CommunityDbUtils.java 469 Avoid empty catch blocks
15 org/cougaar/tools/csmart/core/db/CommunityDbUtils.java 474 These nested if statements could be combined
16 org/cougaar/tools/csmart/core/db/CommunityDbUtils.java 503 Avoid empty catch blocks
17 org/cougaar/tools/csmart/core/db/CommunityDbUtils.java 537 These nested if statements could be combined
18 org/cougaar/tools/csmart/core/db/CommunityDbUtils.java 555 Avoid empty catch blocks
19 org/cougaar/tools/csmart/core/db/CommunityDbUtils.java 594 These nested if statements could be combined
20 org/cougaar/tools/csmart/core/db/CommunityDbUtils.java 613 Avoid empty catch blocks
21 org/cougaar/tools/csmart/core/db/CommunityDbUtils.java 683 Avoid empty catch blocks
22 org/cougaar/tools/csmart/core/db/DBUtils.java 57 Avoid unused private fields such as 'EXPERIMENT_SOCIETY_QUERY'
23 org/cougaar/tools/csmart/core/db/DBUtils.java 251 Avoid empty catch blocks
24 org/cougaar/tools/csmart/core/db/DBUtils.java 285 Avoid empty catch blocks
25 org/cougaar/tools/csmart/core/db/DBUtils.java 304 Avoid empty catch blocks
26 org/cougaar/tools/csmart/core/db/DBUtils.java 805 Avoid empty catch blocks
27 org/cougaar/tools/csmart/core/db/DBUtils.java 840 Avoid empty catch blocks
28 org/cougaar/tools/csmart/core/db/DBUtils.java 1122 Avoid unused private methods such as 'dbGetAgentNames(String)'
29 org/cougaar/tools/csmart/core/db/PDbBase.java 116 Avoid empty catch blocks
30 org/cougaar/tools/csmart/core/db/PDbBase.java 127 Do not use 'if' statements that are always true or always false
31 org/cougaar/tools/csmart/core/db/PDbBase.java 271 Avoid returning from a finally block
32 org/cougaar/tools/csmart/core/db/PDbBase.java 298 Avoid unused private methods such as 'isRecipeUsed(String)'
33 org/cougaar/tools/csmart/core/db/PDbBase.java 484 Avoid returning from a finally block
34 org/cougaar/tools/csmart/core/db/PDbBase.java 540 Avoid empty catch blocks
35 org/cougaar/tools/csmart/core/db/PDbBase.java 545 Avoid empty catch blocks
36 org/cougaar/tools/csmart/core/db/PopulateDb.java 1145 These nested if statements could be combined
37 org/cougaar/tools/csmart/core/db/PopulateDb.java 1743 Avoid empty 'if' statements
38 org/cougaar/tools/csmart/core/db/PopulateDb.java 1926 These nested if statements could be combined
39 org/cougaar/tools/csmart/core/db/PopulateDb.java 2544 Avoid empty 'if' statements
40 org/cougaar/tools/csmart/core/db/PopulateDb.java 2739 Avoid empty 'if' statements
41 org/cougaar/tools/csmart/core/db/PopulateDb.java 3018 Avoid empty catch blocks
42 org/cougaar/tools/csmart/core/db/PopulateDb.java 3168 Avoid empty 'if' statements
43 org/cougaar/tools/csmart/core/db/PopulateDb.java 3212 Avoid empty 'if' statements
44 org/cougaar/tools/csmart/core/db/PopulateDb.java 3355 These nested if statements could be combined
45 org/cougaar/tools/csmart/core/db/PopulateDb.java 3421 Avoid unused private methods such as 'getFullName(ComponentData)'
46 org/cougaar/tools/csmart/core/db/PopulateDb.java 3439 Avoid unused private methods such as 'findAncestorOfType(ComponentData,String)'
47 org/cougaar/tools/csmart/core/property/ConfigurableComponent.java 550 These nested if statements could be combined
48 org/cougaar/tools/csmart/core/property/ConfigurableComponent.java 716 These nested if statements could be combined
49 org/cougaar/tools/csmart/core/property/ConfigurableComponent.java 736 These nested if statements could be combined
50 org/cougaar/tools/csmart/core/property/ConfigurableComponent.java 888 These nested if statements could be combined
51 org/cougaar/tools/csmart/core/property/ConfigurableComponent.java 1134 These nested if statements could be combined
52 org/cougaar/tools/csmart/core/property/ConfigurableComponent.java 1139 These nested if statements could be combined
53 org/cougaar/tools/csmart/core/property/ConfigurableComponent.java 1344 These nested if statements could be combined
54 org/cougaar/tools/csmart/core/property/range/BooleanRange.java 42 Avoid instantiating Boolean objects; you can usually invoke Boolean.TRUE instead.
55 org/cougaar/tools/csmart/core/property/range/RangeBase.java 42 Avoid unused private fields such as 'log'
56 org/cougaar/tools/csmart/core/property/range/StringRange.java 83 Ensure you override both equals() and hashCode()
57 org/cougaar/tools/csmart/experiment/DBExperiment.java 105 Avoid empty catch blocks
58 org/cougaar/tools/csmart/experiment/DBExperiment.java 336 These nested if statements could be combined
59 org/cougaar/tools/csmart/experiment/DBExperiment.java 392 Avoid empty catch blocks
60 org/cougaar/tools/csmart/experiment/DBExperiment.java 545 Avoid empty catch blocks
61 org/cougaar/tools/csmart/experiment/DBExperiment.java 591 These nested if statements could be combined
62 org/cougaar/tools/csmart/experiment/DBExperiment.java 694 These nested if statements could be combined
63 org/cougaar/tools/csmart/experiment/DBExperiment.java 767 These nested if statements could be combined
64 org/cougaar/tools/csmart/experiment/DBExperiment.java 787 Avoid empty catch blocks
65 org/cougaar/tools/csmart/experiment/DBExperiment.java 871 Avoid empty catch blocks
66 org/cougaar/tools/csmart/experiment/ExperimentBase.java 1063 Avoid unused private methods such as 'checkHNA(ComponentData,AgentComponent)'
67 org/cougaar/tools/csmart/experiment/ExperimentBase.java 1217 Avoid empty catch blocks
68 org/cougaar/tools/csmart/experiment/ExperimentBase.java 1426 Avoid empty 'if' statements
69 org/cougaar/tools/csmart/experiment/ExperimentBase.java 1542 Avoid empty 'if' statements
70 org/cougaar/tools/csmart/experiment/ExperimentHost.java 62 Ensure you override both equals() and hashCode()
71 org/cougaar/tools/csmart/experiment/ExperimentINIWriter.java 58 Avoid unused private fields such as 'components'
72 org/cougaar/tools/csmart/experiment/ExperimentINIWriter.java 64 Avoid unused private fields such as 'metricsInitializer'
73 org/cougaar/tools/csmart/experiment/ExperimentINIWriter.java 248 Avoid unnecessary return statements
74 org/cougaar/tools/csmart/experiment/ExperimentINIWriter.java 294 Avoid empty 'if' statements
75 org/cougaar/tools/csmart/experiment/ExperimentINIWriter.java 373 Avoid empty 'if' statements
76 org/cougaar/tools/csmart/experiment/ExperimentINIWriter.java 544 Avoid empty 'if' statements
77 org/cougaar/tools/csmart/experiment/ExperimentNode.java 81 Ensure you override both equals() and hashCode()
78 org/cougaar/tools/csmart/experiment/LeafOnlyConfigWriter.java 56 Avoid unused private fields such as 'components'
79 org/cougaar/tools/csmart/experiment/LeafOnlyConfigWriter.java 133 These nested if statements could be combined
80 org/cougaar/tools/csmart/experiment/Trial.java 48 Avoid unused private fields such as 'log'
81 org/cougaar/tools/csmart/experiment/XMLExperiment.java 315 These nested if statements could be combined
82 org/cougaar/tools/csmart/recipe/AdaptivitySupportRecipe.java 52 Avoid unused private fields such as 'BACKUP_DESCRIPTION'
83 org/cougaar/tools/csmart/recipe/AdaptivitySupportRecipe.java 126 Avoid unused private methods such as 'modifyComponentData(ComponentData,PopulateDb,Set)'
84 org/cougaar/tools/csmart/recipe/AgentQueryProperty.java 81 Overriding method merely calls super
85 org/cougaar/tools/csmart/recipe/AgentQueryProperty.java 85 Avoid unused private methods such as 'getAvailableQueries()'
86 org/cougaar/tools/csmart/recipe/BasicMetric.java 54 Avoid unused private fields such as 'BACKUP_DESCRIPTION'
87 org/cougaar/tools/csmart/recipe/ComplexRecipeBase.java 201 Avoid empty catch blocks
88 org/cougaar/tools/csmart/recipe/ComplexRecipeBase.java 459 These nested if statements could be combined
89 org/cougaar/tools/csmart/recipe/ComponentCollectionRecipe.java 168 These nested if statements could be combined
90 org/cougaar/tools/csmart/recipe/ComponentCollectionRecipe.java 245 Avoid unused private methods such as 'modifyComponentData(ComponentData,PopulateDb,Set,ConfigurableComponent)'
91 org/cougaar/tools/csmart/recipe/ParameterInsertionRecipe.java 43 Avoid unused private fields such as 'BACKUP_DESCRIPTION'
92 org/cougaar/tools/csmart/recipe/ParameterInsertionRecipe.java 109 Avoid unused private methods such as 'modifyComponentData(ComponentData,PopulateDb,Set)'
93 org/cougaar/tools/csmart/recipe/RecipeBase.java 113 Avoid instantiating Boolean objects; you can usually invoke Boolean.TRUE instead.
94 org/cougaar/tools/csmart/recipe/RecipeBase.java 297 Ensure you override both equals() and hashCode()
95 org/cougaar/tools/csmart/recipe/RecipeQueryProperty.java 75 Avoid empty catch blocks
96 org/cougaar/tools/csmart/recipe/ServletGroupInsertionRecipe.java 60 Avoid unused private fields such as 'BACKUP_DESCRIPTION'
97 org/cougaar/tools/csmart/recipe/ServletGroupInsertionRecipe.java 71 Avoid unused private fields such as 'DFLT_SERVLET_CLASS'
98 org/cougaar/tools/csmart/recipe/ServletGroupInsertionRecipe.java 219 Avoid unused private methods such as 'modifyComponentData(ComponentData,PopulateDb,Set)'
99 org/cougaar/tools/csmart/recipe/SpecificInsertionRecipe.java 50 Avoid unused private fields such as 'BACKUP_DESCRIPTION'
100 org/cougaar/tools/csmart/recipe/SpecificInsertionRecipe.java 231 Avoid unused private methods such as 'modifyComponentData(ComponentData,PopulateDb,Set)'
101 org/cougaar/tools/csmart/recipe/SwitchPluginRecipe.java 140 These nested if statements could be combined
102 org/cougaar/tools/csmart/runtime/jni/CpuClock.java 131 Avoid unused local variables such as 'time'
103 org/cougaar/tools/csmart/runtime/jni/CpuClock.java 142 Avoid empty catch blocks
104 org/cougaar/tools/csmart/runtime/jni/ProcCpu.java 114 Avoid empty catch blocks
105 org/cougaar/tools/csmart/runtime/jni/ProcCpu.java 153 Avoid unused local variables such as 'j'
106 org/cougaar/tools/csmart/runtime/jni/ProcCpu.java 168 Avoid empty 'if' statements
107 org/cougaar/tools/csmart/runtime/plugin/CSMARTPlugin.java 135 Avoid empty 'if' statements
108 org/cougaar/tools/csmart/runtime/plugin/CSMARTPlugin.java 152 Avoid empty 'if' statements
109 org/cougaar/tools/csmart/runtime/plugin/CSMARTPlugin.java 169 Avoid empty 'if' statements
110 org/cougaar/tools/csmart/runtime/plugin/MetricsInitializerPlugin.java 339 These nested if statements could be combined
111 org/cougaar/tools/csmart/runtime/plugin/MetricsPlugin.java 212 Avoid unused private fields such as 'taskSearchPred'
112 org/cougaar/tools/csmart/runtime/plugin/MetricsPlugin.java 278 These nested if statements could be combined
113 org/cougaar/tools/csmart/runtime/plugin/MetricsPlugin.java 294 These nested if statements could be combined
114 org/cougaar/tools/csmart/runtime/plugin/MetricsPlugin.java 310 These nested if statements could be combined
115 org/cougaar/tools/csmart/runtime/plugin/MetricsPlugin.java 327 These nested if statements could be combined
116 org/cougaar/tools/csmart/runtime/plugin/MetricsPlugin.java 334 These nested if statements could be combined
117 org/cougaar/tools/csmart/runtime/plugin/MetricsPlugin.java 352 These nested if statements could be combined
118 org/cougaar/tools/csmart/runtime/plugin/MetricsPlugin.java 447 Avoid empty 'if' statements
119 org/cougaar/tools/csmart/runtime/plugin/MetricsPlugin.java 461 These nested if statements could be combined
120 org/cougaar/tools/csmart/runtime/plugin/MetricsPlugin.java 462 These nested if statements could be combined
121 org/cougaar/tools/csmart/runtime/plugin/MetricsPlugin.java 495 Avoid empty 'if' statements
122 org/cougaar/tools/csmart/runtime/plugin/MetricsPlugin.java 586 These nested if statements could be combined
123 org/cougaar/tools/csmart/runtime/plugin/MetricsPlugin.java 805 These nested if statements could be combined
124 org/cougaar/tools/csmart/runtime/plugin/MetricsPlugin.java 819 These nested if statements could be combined
125 org/cougaar/tools/csmart/society/AgentBase.java 196 Ensure you override both equals() and hashCode()
126 org/cougaar/tools/csmart/society/ComponentBase.java 118 These nested if statements could be combined
127 org/cougaar/tools/csmart/society/PropGroupBase.java 53 Avoid unused private fields such as 'log'
128 org/cougaar/tools/csmart/society/RelationshipBase.java 102 These nested if statements could be combined
129 org/cougaar/tools/csmart/society/SocietyBase.java 340 Avoid empty catch blocks
130 org/cougaar/tools/csmart/society/SocietyComponentCreator.java 101 Avoid unused private methods such as 'addContainer(ComponentData,BaseComponent,String)'
131 org/cougaar/tools/csmart/society/SocietyComponentCreator.java 117 Avoid unused private methods such as 'addPropertiesAsParameters(ComponentData,BaseComponent)'
132 org/cougaar/tools/csmart/society/SocietyComponentCreator.java 125 These nested if statements could be combined
133 org/cougaar/tools/csmart/society/cdata/AgentCDataComponent.java 116 Avoid empty 'if' statements
134 org/cougaar/tools/csmart/society/db/AssetDBComponent.java 352 These nested if statements could be combined
135 org/cougaar/tools/csmart/society/db/AssetDBComponent.java 487 Avoid unused formal parameters such as 'endDate'
136 org/cougaar/tools/csmart/society/db/AssetDBComponent.java 487 Avoid unused formal parameters such as 'startDate'
137 org/cougaar/tools/csmart/society/db/SocietyDBComponent.java 59 Avoid unused private fields such as 'substitutions'
138 org/cougaar/tools/csmart/society/file/SocietyFileComponent.java 42 Avoid unused private fields such as 'name'
139 org/cougaar/tools/csmart/ui/analyzer/Analyzer.java 52 Avoid unused private fields such as 'EXCEL'
140 org/cougaar/tools/csmart/ui/analyzer/Analyzer.java 72 Avoid unused private fields such as 'myFrame'
141 org/cougaar/tools/csmart/ui/analyzer/Analyzer.java 75 Avoid unused private fields such as 'process'
142 org/cougaar/tools/csmart/ui/community/CommunityDNDTree.java 252 Avoid unused private methods such as 'addElement(DefaultMutableTreeNode,DefaultMutableTreeNode,DefaultMutableTreeNode)'
143 org/cougaar/tools/csmart/ui/community/CommunityPanel.java 147 These nested if statements could be combined
144 org/cougaar/tools/csmart/ui/community/CommunityPanel.java 161 These nested if statements could be combined
145 org/cougaar/tools/csmart/ui/community/CommunityPanel.java 489 These nested if statements could be combined
146 org/cougaar/tools/csmart/ui/community/CommunityTreeModelListener.java 46 Avoid unused private fields such as 'communityTableUtils'
147 org/cougaar/tools/csmart/ui/community/CommunityTreeObject.java 218 Avoid unused formal parameters such as 'os'
148 org/cougaar/tools/csmart/ui/community/CommunityTreeObject.java 222 Avoid unused formal parameters such as 'is'
149 org/cougaar/tools/csmart/ui/community/DatabaseTableModel.java 170 Avoid empty catch blocks
150 org/cougaar/tools/csmart/ui/community/DatabaseTableModel.java 257 Avoid unused local variables such as 'typeName'
151 org/cougaar/tools/csmart/ui/community/DatabaseTableModel.java 297 These nested if statements could be combined
152 org/cougaar/tools/csmart/ui/community/EntityDNDTree.java 55 Avoid unused private fields such as 'log'
153 org/cougaar/tools/csmart/ui/community/TableSorter.java 54 Avoid unused private fields such as 'compares'
154 org/cougaar/tools/csmart/ui/community/TableSorter.java 55 Avoid unused private fields such as 'nColumns'
155 org/cougaar/tools/csmart/ui/community/TableSorter.java 200 These nested if statements could be combined
156 org/cougaar/tools/csmart/ui/community/TableSorter.java 206 Avoid unused formal parameters such as 'sender'
157 org/cougaar/tools/csmart/ui/configbuilder/PropertyBuilder.java 141 These nested if statements could be combined
158 org/cougaar/tools/csmart/ui/configbuilder/PropertyEditorPanel.java 186 Avoid unused private fields such as 'addAssetParameterAction'
159 org/cougaar/tools/csmart/ui/configbuilder/PropertyEditorPanel.java 215 Avoid unused private fields such as 'addRecipeParameterAction'
160 org/cougaar/tools/csmart/ui/configbuilder/PropertyEditorPanel.java 674 Avoid empty 'if' statements
161 org/cougaar/tools/csmart/ui/configbuilder/PropertyEditorPanel.java 1134 Avoid unused private methods such as 'addPropGroupParameter()'
162 org/cougaar/tools/csmart/ui/configbuilder/PropertyEditorPanel.java 1194 Avoid unused private methods such as 'addTarget()'
163 org/cougaar/tools/csmart/ui/configbuilder/PropertyEditorPanel.java 1198 Avoid unused formal parameters such as 'getName'
164 org/cougaar/tools/csmart/ui/configbuilder/PropertyEditorPanel.java 1221 Avoid empty catch blocks
165 org/cougaar/tools/csmart/ui/configbuilder/PropertyTable.java 208 Avoid instantiating Boolean objects; you can usually invoke Boolean.TRUE instead.
166 org/cougaar/tools/csmart/ui/console/AppServerSupport.java 151 These nested if statements could be combined
167 org/cougaar/tools/csmart/ui/console/AppServerSupport.java 248 Avoid unused local variables such as 'appServer'
168 org/cougaar/tools/csmart/ui/console/CSMARTConsoleModel.java 128 Avoid empty catch blocks
169 org/cougaar/tools/csmart/ui/console/CSMARTConsoleModel.java 352 Avoid empty catch blocks
170 org/cougaar/tools/csmart/ui/console/CSMARTConsoleView.java 561 Avoid unused formal parameters such as 'e'
171 org/cougaar/tools/csmart/ui/console/CSMARTConsoleView.java 625 Avoid empty catch blocks
172 org/cougaar/tools/csmart/ui/console/CSMARTConsoleView.java 886 Avoid unused local variables such as 'ccv'
173 org/cougaar/tools/csmart/ui/console/CSMARTConsoleView.java 924 Avoid empty catch blocks
174 org/cougaar/tools/csmart/ui/console/CSMARTConsoleView.java 1178 Avoid empty catch blocks
175 org/cougaar/tools/csmart/ui/console/ConsoleDesktop.java 150 Avoid unused private methods such as 'componentResized(Component)'
176 org/cougaar/tools/csmart/ui/console/ConsoleDesktop.java 167 Avoid empty catch blocks
177 org/cougaar/tools/csmart/ui/console/ConsoleNodeListener.java 107 Avoid empty catch blocks
178 org/cougaar/tools/csmart/ui/console/ConsoleNodeListener.java 226 Avoid empty catch blocks
179 org/cougaar/tools/csmart/ui/console/ConsoleNodeListener.java 281 These nested if statements could be combined
180 org/cougaar/tools/csmart/ui/console/ConsoleNodeListener.java 290 These nested if statements could be combined
181 org/cougaar/tools/csmart/ui/console/ConsoleNodeListener.java 360 These nested if statements could be combined
182 org/cougaar/tools/csmart/ui/console/NodeView.java 418 Avoid empty catch blocks
183 org/cougaar/tools/csmart/ui/experiment/AgentInfoPanel.java 69 These nested if statements could be combined
184 org/cougaar/tools/csmart/ui/experiment/ExperimentBuilder.java 140 Avoid empty catch blocks
185 org/cougaar/tools/csmart/ui/experiment/ExperimentBuilder.java 141 Avoid empty catch blocks
186 org/cougaar/tools/csmart/ui/experiment/ExperimentTree.java 240 Avoid unused private methods such as 'addElement(Object,DataFlavor,DefaultMutableTreeNode,DefaultMutableTreeNode)'
187 org/cougaar/tools/csmart/ui/experiment/ExperimentTree.java 279 These nested if statements could be combined
188 org/cougaar/tools/csmart/ui/experiment/HostConfigurationBuilder.java 1104 Avoid empty 'if' statements
189 org/cougaar/tools/csmart/ui/experiment/HostConfigurationBuilder.java 1114 Avoid empty 'if' statements
190 org/cougaar/tools/csmart/ui/experiment/NodeArgumentDialog.java 260 Avoid empty catch blocks
191 org/cougaar/tools/csmart/ui/experiment/ThreadBuilder.java 101 Avoid instantiating Boolean objects; you can usually invoke Boolean.TRUE instead.
192 org/cougaar/tools/csmart/ui/experiment/ThreadBuilder.java 134 Avoid instantiating Boolean objects; you can usually invoke Boolean.TRUE instead.
193 org/cougaar/tools/csmart/ui/experiment/UnboundPropertyBuilder.java 58 Avoid unused private fields such as 'experimentBuilder'
194 org/cougaar/tools/csmart/ui/experiment/UnboundPropertyBuilder.java 91 Avoid unused private fields such as 'societiesActions'
195 org/cougaar/tools/csmart/ui/experiment/UnboundPropertyBuilder.java 260 These nested if statements could be combined
196 org/cougaar/tools/csmart/ui/monitor/community/ULCommunityNode.java 131 Avoid unused private methods such as 'setNodeShapeParameters()'
197 org/cougaar/tools/csmart/ui/monitor/community/ULCommunityTableModel.java 50 Avoid unused private fields such as 'log'
198 org/cougaar/tools/csmart/ui/monitor/generic/BirdFrame.java 44 Avoid unused private fields such as 'initSize'
199 org/cougaar/tools/csmart/ui/monitor/generic/BirdFrame.java 45 Avoid unused private fields such as 'log'
200 org/cougaar/tools/csmart/ui/monitor/generic/BirdPanel.java 40 Avoid unused private fields such as 'log'
201 org/cougaar/tools/csmart/ui/monitor/generic/CSMARTFrame.java 132 Avoid unused private fields such as 'newMenu'
202 org/cougaar/tools/csmart/ui/monitor/generic/CSMARTGraph.java 427 These nested if statements could be combined
203 org/cougaar/tools/csmart/ui/monitor/generic/CSMARTGraph.java 506 These nested if statements could be combined
204 org/cougaar/tools/csmart/ui/monitor/generic/CSMARTGraph.java 910 Avoid unused private methods such as 'printGraphAttributes()'
205 org/cougaar/tools/csmart/ui/monitor/generic/CSMARTGraph.java 1027 These nested if statements could be combined
206 org/cougaar/tools/csmart/ui/monitor/generic/CSMARTGraph.java 1092 These nested if statements could be combined
207 org/cougaar/tools/csmart/ui/monitor/generic/CSMARTGraph.java 1147 Avoid unused private methods such as 'removeNodesWorker(Vector,boolean)'
208 org/cougaar/tools/csmart/ui/monitor/generic/CSMARTGraph.java 1678 Avoid unused private methods such as 'UIDToLabel(String)'
209 org/cougaar/tools/csmart/ui/monitor/generic/CSMARTGraph.java 1696 These nested if statements could be combined
210 org/cougaar/tools/csmart/ui/monitor/generic/CSMARTGraph.java 1900 These nested if statements could be combined
211 org/cougaar/tools/csmart/ui/monitor/generic/CSMARTGraph.java 1933 These nested if statements could be combined
212 org/cougaar/tools/csmart/ui/monitor/generic/CSMARTGrappaAdapter.java 53 Avoid unused private fields such as 'log'
213 org/cougaar/tools/csmart/ui/monitor/generic/CSMARTGrappaAdapter.java 145 Avoid unnecessary return statements
214 org/cougaar/tools/csmart/ui/monitor/generic/CSMARTGrappaAdapter.java 162 These nested if statements could be combined
215 org/cougaar/tools/csmart/ui/monitor/generic/ExtensionFileFilter.java 145 An empty statement (semicolon) not part of a loop
216 org/cougaar/tools/csmart/ui/monitor/generic/ExtensionFileFilter.java 162 An empty statement (semicolon) not part of a loop
217 org/cougaar/tools/csmart/ui/monitor/generic/LegendComboBoxModel.java 95 Ensure you override both equals() and hashCode()
218 org/cougaar/tools/csmart/ui/monitor/generic/UIProperties.java 104 Avoid unused private methods such as 'printColors()'
219 org/cougaar/tools/csmart/ui/monitor/plan/ULPlanFinder.java 1365 These nested if statements could be combined
220 org/cougaar/tools/csmart/ui/monitor/plan/ULPlanFinder.java 1716 Avoid unused private methods such as 'getNodesWithFloatAttribute(Vector,String,float)'
221 org/cougaar/tools/csmart/ui/monitor/plan/ULPlanFinder.java 1740 Avoid unused private methods such as 'getNodesWithLongAttribute(Vector,String,long)'
222 org/cougaar/tools/csmart/ui/monitor/plan/ULPlanFinder.java 1773 These nested if statements could be combined
223 org/cougaar/tools/csmart/ui/monitor/plan/ULPlanFinder.java 1783 Avoid unused private methods such as 'getNodesInChoiceCommunity(Vector,String)'
224 org/cougaar/tools/csmart/ui/monitor/plan/ULPlanFinder.java 1792 These nested if statements could be combined
225 org/cougaar/tools/csmart/ui/monitor/plan/ULPlanFinder.java 1800 Avoid unused private methods such as 'getNodesWithEitherAttribute(Vector,String,String,String)'
226 org/cougaar/tools/csmart/ui/monitor/plan/ULPlanFinder.java 1809 These nested if statements could be combined
227 org/cougaar/tools/csmart/ui/monitor/plan/ULPlanFinder.java 1883 Ensure you override both equals() and hashCode()
228 org/cougaar/tools/csmart/ui/monitor/plan/ULPlanNode.java 101 These nested if statements could be combined
229 org/cougaar/tools/csmart/ui/monitor/plan/ULPlanNode.java 125 These nested if statements could be combined
230 org/cougaar/tools/csmart/ui/monitor/plan/ULPlanNode.java 456 Avoid unused private methods such as 'printProperties(PropertyTree)'
231 org/cougaar/tools/csmart/ui/monitor/plan/ULPlanTableModel.java 217 Avoid unused private methods such as 'addNamedAttribute(String)'
232 org/cougaar/tools/csmart/ui/monitor/society/ULSocietyFrame.java 136 Overriding method merely calls super
233 org/cougaar/tools/csmart/ui/monitor/society/ULSocietyFrame.java 354 These nested if statements could be combined
234 org/cougaar/tools/csmart/ui/monitor/society/ULSocietyTableModel.java 53 Avoid unused private fields such as 'log'
235 org/cougaar/tools/csmart/ui/monitor/society/ULSocietyTableModel.java 155 Ensure you override both equals() and hashCode()
236 org/cougaar/tools/csmart/ui/monitor/topology/TableSorter.java 47 Avoid unused private fields such as 'compares'
237 org/cougaar/tools/csmart/ui/monitor/topology/TableSorter.java 205 Avoid unused formal parameters such as 'sender'
238 org/cougaar/tools/csmart/ui/monitor/topology/TopologyFrame.java 137 Avoid unused local variables such as 'agent'
239 org/cougaar/tools/csmart/ui/monitor/topology/TopologyFrame.java 137 Avoid unused local variables such as 'host'
240 org/cougaar/tools/csmart/ui/monitor/topology/TopologyFrame.java 137 Avoid unused local variables such as 'port'
241 org/cougaar/tools/csmart/ui/monitor/topology/TopologyService.java 72 Avoid unused private methods such as 'getAgentLocations(String)'
242 org/cougaar/tools/csmart/ui/monitor/topology/TopologyService.java 106 Avoid unused private methods such as 'getFakeData()'
243 org/cougaar/tools/csmart/ui/monitor/viewer/CSMARTUL.java 90 Avoid unused private fields such as 'SEPARATOR'
244 org/cougaar/tools/csmart/ui/monitor/viewer/CSMARTUL.java 703 Avoid unused private methods such as 'getObjectsFromServlet(Vector,String,ArrayList,ArrayList,int)'
245 org/cougaar/tools/csmart/ui/monitor/viewer/CSMARTUL.java 919 Avoid unused local variables such as 'nDuplicates'
246 org/cougaar/tools/csmart/ui/monitor/viewer/CSMARTUL.java 1149 These nested if statements could be combined
247 org/cougaar/tools/csmart/ui/monitor/viewer/ThreadUtils.java 190 These nested if statements could be combined
248 org/cougaar/tools/csmart/ui/monitor/viewer/ThreadUtils.java 205 These nested if statements could be combined
249 org/cougaar/tools/csmart/ui/monitor/viewer/ThreadUtils.java 218 These nested if statements could be combined
250 org/cougaar/tools/csmart/ui/monitor/viewer/ThreadUtils.java 248 These nested if statements could be combined
251 org/cougaar/tools/csmart/ui/monitor/viewer/ThreadUtils.java 265 These nested if statements could be combined
252 org/cougaar/tools/csmart/ui/monitor/viewer/ThreadUtils.java 285 These nested if statements could be combined
253 org/cougaar/tools/csmart/ui/monitor/xml/XMLFrame.java 109 Avoid empty catch blocks
254 org/cougaar/tools/csmart/ui/monitor/xml/XMLFrame.java 152 Avoid unused local variables such as 'nodeName'
255 org/cougaar/tools/csmart/ui/monitor/xml/XMLFrame.java 240 Avoid unused private methods such as 'getNodeType(org.w3c.dom.Node)'
256 org/cougaar/tools/csmart/ui/monitor/xml/XMLHandler.java 202 Avoid unused local variables such as 'memoryUsage'
257 org/cougaar/tools/csmart/ui/monitor/xml/XMLHandler.java 203 Avoid unused local variables such as 'tagginess'
258 org/cougaar/tools/csmart/ui/monitor/xml/XMLHandler.java 317 Avoid empty catch blocks
259 org/cougaar/tools/csmart/ui/monitor/xml/XMLHandler.java 326 Avoid empty catch blocks
260 org/cougaar/tools/csmart/ui/monitor/xml/XMLHandler.java 335 Avoid empty catch blocks
261 org/cougaar/tools/csmart/ui/monitor/xml/XMLHandler.java 347 Avoid empty catch blocks
262 org/cougaar/tools/csmart/ui/monitor/xml/XMLMarker.java 51 Avoid unused private fields such as 'colorCB'
263 org/cougaar/tools/csmart/ui/monitor/xml/XMLMarker.java 52 Avoid unused private fields such as 'colorNames'
264 org/cougaar/tools/csmart/ui/monitor/xml/XMLNode.java 229 Avoid unused private methods such as 'setNodeShapeParameters()'
265 org/cougaar/tools/csmart/ui/monitor/xml/XMLTableModel.java 49 Avoid unused private fields such as 'log'
266 org/cougaar/tools/csmart/ui/monitor/xml/XMLTableModel.java 151 Avoid unused private methods such as 'addAttribute(String)'
267 org/cougaar/tools/csmart/ui/monitor/xml/XMLTableModel.java 193 Ensure you override both equals() and hashCode()
268 org/cougaar/tools/csmart/ui/servlet/CommunityProviderServlet.java 236 These nested if statements could be combined
269 org/cougaar/tools/csmart/ui/servlet/SearchServlet.java 152 Avoid unused private fields such as 'htmlout'
270 org/cougaar/tools/csmart/ui/servlet/SearchServlet.java 195 Avoid empty catch blocks
271 org/cougaar/tools/csmart/ui/servlet/SearchServlet.java 742 Avoid empty 'if' statements
272 org/cougaar/tools/csmart/ui/servlet/SearchServlet.java 753 Avoid empty 'if' statements
273 org/cougaar/tools/csmart/ui/servlet/TranslateUtils.java 471 Unnecessary final modifier in final class
274 org/cougaar/tools/csmart/ui/tree/ConsoleDNDTree.java 156 Avoid empty 'if' statements
275 org/cougaar/tools/csmart/ui/tree/ConsoleDNDTree.java 194 Avoid unused private methods such as 'addElement(DefaultMutableTreeNode,DefaultMutableTreeNode,DefaultMutableTreeNode)'
276 org/cougaar/tools/csmart/ui/tree/ConsoleTreeObject.java 159 Avoid unused formal parameters such as 'os'
277 org/cougaar/tools/csmart/ui/tree/ConsoleTreeObject.java 163 Avoid unused formal parameters such as 'is'
278 org/cougaar/tools/csmart/ui/tree/DNDTree.java 167 Avoid empty 'if' statements
279 org/cougaar/tools/csmart/ui/tree/DNDTree.java 173 Avoid empty 'if' statements
280 org/cougaar/tools/csmart/ui/viewer/ActionUtil.java 138 Avoid unnecessary return statements
281 org/cougaar/tools/csmart/ui/viewer/ActionUtil.java 202 These nested if statements could be combined
282 org/cougaar/tools/csmart/ui/viewer/ActionUtil.java 240 These nested if statements could be combined
283 org/cougaar/tools/csmart/ui/viewer/ActionUtil.java 285 These nested if statements could be combined
284 org/cougaar/tools/csmart/ui/viewer/CMTDialog.java 138 Avoid instantiating Boolean objects; you can usually invoke Boolean.TRUE instead.
285 org/cougaar/tools/csmart/ui/viewer/CMTDialog.java 176 Avoid instantiating Boolean objects; you can usually invoke Boolean.TRUE instead.
286 org/cougaar/tools/csmart/ui/viewer/CMTDialog.java 360 Avoid empty catch blocks
287 org/cougaar/tools/csmart/ui/viewer/CSMART.java 230 Avoid empty catch blocks
288 org/cougaar/tools/csmart/ui/viewer/CSMART.java 1026 Avoid empty catch blocks
289 org/cougaar/tools/csmart/ui/viewer/CSMART.java 1058 Avoid empty catch blocks
290 org/cougaar/tools/csmart/ui/viewer/Organizer.java 129 Avoid unused private fields such as 'recipes'
291 org/cougaar/tools/csmart/ui/viewer/Organizer.java 352 These nested if statements could be combined
292 org/cougaar/tools/csmart/ui/viewer/Organizer.java 633 These nested if statements could be combined
293 org/cougaar/tools/csmart/ui/viewer/Organizer.java 1228 These nested if statements could be combined
294 org/cougaar/tools/csmart/ui/viewer/Organizer.java 1460 These nested if statements could be combined
295 org/cougaar/tools/csmart/ui/viewer/Organizer.java 1816 Avoid unused private methods such as 'displayExperimentsInWorkspace(SocietyComponent)'
296 org/cougaar/tools/csmart/ui/viewer/Organizer.java 1837 Avoid unused private methods such as 'displayExperimentsInWorkspace(RecipeComponent)'
297 org/cougaar/tools/csmart/ui/viewer/Organizer.java 2089 These nested if statements could be combined
298 org/cougaar/tools/csmart/ui/viewer/OrganizerHelper.java 72 Avoid unused private fields such as 'EXPT_DESC_QUERY'
299 org/cougaar/tools/csmart/ui/viewer/OrganizerHelper.java 74 Avoid unused private fields such as 'EXPT_TRIAL_QUERY'
300 org/cougaar/tools/csmart/ui/viewer/OrganizerHelper.java 246 Avoid empty catch blocks
301 org/cougaar/tools/csmart/ui/viewer/OrganizerHelper.java 272 Avoid empty catch blocks
302 org/cougaar/tools/csmart/ui/viewer/OrganizerHelper.java 298 Avoid empty catch blocks
303 org/cougaar/tools/csmart/ui/viewer/OrganizerHelper.java 326 Avoid empty catch blocks
304 org/cougaar/tools/csmart/ui/viewer/OrganizerHelper.java 414 Avoid empty catch blocks
305 org/cougaar/tools/csmart/ui/viewer/OrganizerHelper.java 498 Avoid unused formal parameters such as 'trialId'
306 org/cougaar/tools/csmart/ui/viewer/OrganizerHelper.java 902 Avoid empty catch blocks
307 org/cougaar/tools/csmart/ui/viewer/OrganizerHelper.java 1275 Ensure you override both equals() and hashCode()
308 org/cougaar/tools/csmart/ui/viewer/OrganizerTree.java 300 Avoid unused private methods such as 'addElement(Object,DefaultMutableTreeNode,DefaultMutableTreeNode)'
309 org/cougaar/tools/csmart/ui/viewer/SocietyFinder.java 65 Avoid empty catch blocks
310 org/cougaar/tools/csmart/ui/viewer/SocietyFinder.java 73 Avoid empty catch blocks
311 org/cougaar/tools/csmart/ui/viewer/SocietyFinder.java 224 Avoid empty 'if' statements
312 org/cougaar/tools/csmart/ui/viewer/SocietyFinder.java 252 Avoid empty catch blocks
313 org/cougaar/tools/csmart/util/ArgValue.java 132 Ensure you override both equals() and hashCode()
314 org/cougaar/tools/csmart/util/EarthConstants.java 140 Unnecessary final modifier in final class
315 org/cougaar/tools/csmart/util/EarthConstants.java 163 Unnecessary final modifier in final class
316 org/cougaar/tools/csmart/util/EarthConstants.java 179 Unnecessary final modifier in final class
317 org/cougaar/tools/csmart/util/EarthConstants.java 199 Unnecessary final modifier in final class
318 org/cougaar/tools/csmart/util/EarthConstants.java 231 Unnecessary final modifier in final class
319 org/cougaar/tools/csmart/util/EarthConstants.java 247 Unnecessary final modifier in final class
320 org/cougaar/tools/csmart/util/EarthConstants.java 259 Unnecessary final modifier in final class
321 org/cougaar/tools/csmart/util/EarthConstants.java 268 Unnecessary final modifier in final class
322 org/cougaar/tools/csmart/util/EarthConstants.java 277 Unnecessary final modifier in final class
323 org/cougaar/tools/csmart/util/EarthConstants.java 286 Unnecessary final modifier in final class
324 org/cougaar/tools/csmart/util/EarthConstants.java 295 Unnecessary final modifier in final class
325 org/cougaar/tools/csmart/util/EarthConstants.java 311 Unnecessary final modifier in final class
326 org/cougaar/tools/csmart/util/EarthConstants.java 330 Unnecessary final modifier in final class
327 org/cougaar/tools/csmart/util/EarthConstants.java 343 Unnecessary final modifier in final class
328 org/cougaar/tools/csmart/util/ExportExperimentHelper.java 145 Avoid empty catch blocks
329 org/cougaar/tools/csmart/util/NamedLocationImpl.java 72 Avoid empty catch blocks
330 org/cougaar/tools/csmart/util/NamedLocationImpl.java 231 Ensure you override both equals() and hashCode()
331 org/cougaar/tools/csmart/util/PrototypeParser.java 70 Avoid unused private fields such as 'ETERNITY'
332 org/cougaar/tools/csmart/util/PrototypeParser.java 386 Avoid unused private methods such as 'setTypeIdentificationPG()'
333 org/cougaar/tools/csmart/util/PrototypeParser.java 429 Avoid unused private methods such as 'setClusterPG(String)'
334 org/cougaar/tools/csmart/util/PrototypeParser.java 444 Avoid unused private methods such as 'setCommunityPG()'
335 org/cougaar/tools/csmart/util/SchemaValidate.java 83 Avoid unused private methods such as 'traverse(Node)'
336 org/cougaar/tools/csmart/util/SchemaValidate.java 114 Avoid unused local variables such as 'validatingDOM'
337 org/cougaar/tools/csmart/util/Sorting.java 39 Unnecessary final modifier in final class
338 org/cougaar/tools/csmart/util/Sorting.java 57 Unnecessary final modifier in final class
339 org/cougaar/tools/csmart/util/Sorting.java 82 Unnecessary final modifier in final class
340 org/cougaar/tools/csmart/util/XMLUtils.java 103 Avoid unused private methods such as 'loadXMLFile(InputStream,String)'